Harden configuration restore and polish the v1 release#182
Draft
BrettKinny wants to merge 1 commit into
Draft
Conversation
Review: Harden configuration restore and polish the v1 releaseOverall this is a well-scoped, well-tested follow-up. The namespace-URI fix addresses a real correctness gap, Correctness
Code quality
Test coverage
Minor/non-blocking
SecurityNothing concerning — Nice PR — the fixes are targeted, well-tested, and the docs/CLAUDE.md updates track the behavior changes accurately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This follows up the v1.0.0 release review with the correctness fixes, permanent
regression coverage, and documentation polish identified during the audit.
Why
OPC UA numeric namespace indexes are allocated per session, but saved monitored
nodes relied on those indexes alone. A server restart or configuration change
could therefore make a saved node resolve incorrectly. The CLI also exposed
--connectwithout implementing the connection, the project had no terminal-free--versioncommand, and parts of the README had drifted from the pinned toolchainand actual keyboard behavior.
What changed
against the active session, while retaining backward compatibility with existing
numeric-only configuration files.
--connectstartup and--version, share version formattingwith the About dialog, and avoid printing fatal stack traces to users.
and version output.
shortcuts, certificate guidance, and the exact SDK 10.0.109 requirement.
tooling and assets that drive the normal application UI.
Impact
Saved configurations are safer across OPC UA namespace-table changes, command-line
startup is complete and scriptable, and the public documentation now matches the
application and build environment. Existing configuration files remain supported.
Validation
dotnet test Opcilloscope.sln --configuration Release --no-restore— 833 passeddotnet test Tests/Opcilloscope.E2ETests/Opcilloscope.E2ETests.csproj --configuration Release --no-restore— 13 passed against a fresh published binary over real PTYsdotnet format Opcilloscope.sln --verify-no-changes --no-restorebash -n install.sh uninstall.sh scripts/capture-media.shgit diff --cached --checkscripts/verify-third-party-inventory.sh