diff --git a/package-lock.json b/package-lock.json index 990daa0..6abbee2 100644 --- a/package-lock.json +++ b/package-lock.json @@ -7,7 +7,7 @@ "devDependencies": { "@commitlint/cli": "21.2.1", "@commitlint/config-conventional": "21.2.0", - "conventional-changelog-conventionalcommits": "10.2.1", + "conventional-changelog-conventionalcommits": "9.3.1", "husky": "^9.1.7", "semantic-release": "25.0.7" } @@ -134,6 +134,19 @@ "node": ">=22.12.0" } }, + "node_modules/@commitlint/config-conventional/node_modules/conventional-changelog-conventionalcommits": { + "version": "10.2.1", + "resolved": "https://registry.npmjs.org/conventional-changelog-conventionalcommits/-/conventional-changelog-conventionalcommits-10.2.1.tgz", + "integrity": "sha512-n4Kr1HFMTf3iMbES0TMxKIcYtUUv4rKqyQQp2JwfOEfFCOfGT3Tq4mCyJ8S9/YPyWhydjfKrrvnyl+gCjA+mJQ==", + "dev": true, + "license": "ISC", + "dependencies": { + "@conventional-changelog/template": "^1.2.1" + }, + "engines": { + "node": ">=22" + } + }, "node_modules/@commitlint/config-validator": { "version": "21.2.0", "resolved": "https://registry.npmjs.org/@commitlint/config-validator/-/config-validator-21.2.0.tgz", @@ -487,6 +500,7 @@ "integrity": "sha512-DhGl4xMVFGVIyMwswXeyzdL4uXD5OGILGX5N8Y+f6W7LhC1Ze2poSNrkF/fedpVDHEEZ+PHFW0vL14I+mm8K3Q==", "dev": true, "license": "MIT", + "peer": true, "dependencies": { "@octokit/auth-token": "^6.0.0", "@octokit/graphql": "^9.0.3", @@ -1468,16 +1482,16 @@ } }, "node_modules/conventional-changelog-conventionalcommits": { - "version": "10.2.1", - "resolved": "https://registry.npmjs.org/conventional-changelog-conventionalcommits/-/conventional-changelog-conventionalcommits-10.2.1.tgz", - "integrity": "sha512-n4Kr1HFMTf3iMbES0TMxKIcYtUUv4rKqyQQp2JwfOEfFCOfGT3Tq4mCyJ8S9/YPyWhydjfKrrvnyl+gCjA+mJQ==", + "version": "9.3.1", + "resolved": "https://registry.npmjs.org/conventional-changelog-conventionalcommits/-/conventional-changelog-conventionalcommits-9.3.1.tgz", + "integrity": "sha512-dTYtpIacRpcZgrvBYvBfArMmK2xvIpv2TaxM0/ZI5CBtNUzvF2x0t15HsbRABWprS6UPmvj+PzHVjSx4qAVKyw==", "dev": true, "license": "ISC", "dependencies": { - "@conventional-changelog/template": "^1.2.1" + "compare-func": "^2.0.0" }, "engines": { - "node": ">=22" + "node": ">=18" } }, "node_modules/conventional-changelog-writer": { @@ -1553,6 +1567,7 @@ "integrity": "sha512-hr4ihw+DBqcvrsEDioRO31Z17x71pUYoNe/4h6Z0wB72p7MU7/9gH8Q3s12NFhHPfYBBOV3qyfUxmr/Yn3shnQ==", "dev": true, "license": "MIT", + "peer": true, "dependencies": { "env-paths": "^2.2.1", "import-fresh": "^3.3.0", @@ -2701,6 +2716,7 @@ "integrity": "sha512-8dD6FusOQSrpv9Z1rdNMdlSgQOIP880DHqnohobOmYLElGEqAL/JvxvuxZO16r4HtjTlfPRDC1hbvxC9dPN2nA==", "dev": true, "license": "MIT", + "peer": true, "bin": { "marked": "bin/marked.js" }, @@ -4718,6 +4734,7 @@ "dev": true, "inBundle": true, "license": "MIT", + "peer": true, "engines": { "node": ">=12" }, @@ -5313,6 +5330,7 @@ "integrity": "sha512-fFiUD7LNFI0TOGkc49WDHUX4GYKrOMDKct5ReSB1EJCZiPsPdbIPIJGys1xb2ILpK1v9JMsRkjJQgTRpbr7DgQ==", "dev": true, "license": "MIT", + "peer": true, "dependencies": { "@semantic-release/commit-analyzer": "^13.0.1", "@semantic-release/error": "^4.0.0", @@ -5903,6 +5921,7 @@ "integrity": "sha512-QP88BAKvMam/3NxH6vj2o21R6MjxZUAd6nlwAS/pnGvN9IVLocLHxGYIzFhg6fUQ+5th6P4dv4eW9jX3DSIj7A==", "dev": true, "license": "MIT", + "peer": true, "engines": { "node": ">=12" }, @@ -6006,8 +6025,7 @@ "resolved": "https://registry.npmjs.org/undici-types/-/undici-types-7.24.6.tgz", "integrity": "sha512-WRNW+sJgj5OBN4/0JpHFqtqzhpbnV0GuB+OozA9gCL7a993SmU+1JBZCzLNxYsbMfIeDL+lTsphD5jN5N+n0zg==", "dev": true, - "license": "MIT", - "peer": true + "license": "MIT" }, "node_modules/unicode-emoji-modifier-base": { "version": "1.0.0", diff --git a/package.json b/package.json index 401611d..02fe252 100644 --- a/package.json +++ b/package.json @@ -4,7 +4,7 @@ "devDependencies": { "@commitlint/cli": "21.2.1", "@commitlint/config-conventional": "21.2.0", - "conventional-changelog-conventionalcommits": "10.2.1", + "conventional-changelog-conventionalcommits": "9.3.1", "husky": "^9.1.7", "semantic-release": "25.0.7" }, diff --git a/templates/_helpers.tpl b/templates/_helpers.tpl index 778d5c4..da8c70d 100644 --- a/templates/_helpers.tpl +++ b/templates/_helpers.tpl @@ -27,7 +27,7 @@ If release name contains chart name it will be used as a full name. Create chart name and version as used by the chart label. */}} {{- define "git-hubby.chart" -}} -{{- printf "%s-%s" .Chart.Name .Chart.Version | replace "+" "_" | trunc 63 | trimSuffix "-" }} +{{- printf "%s-%s" .Chart.Name .Chart.Version | replace "+" "_" | trunc 63 | trimAll "-._" }} {{- end }} {{/* diff --git a/tests/labels_test.yaml b/tests/labels_test.yaml new file mode 100644 index 0000000..7976a4a --- /dev/null +++ b/tests/labels_test.yaml @@ -0,0 +1,38 @@ +suite: labels +templates: + - deployment.yaml +release: + name: test-release + namespace: test-ns +tests: + - it: should set helm.sh/chart label with name and version + asserts: + - equal: + path: metadata.labels["helm.sh/chart"] + value: "git-hubby-0.0.1" + + - it: should set app.kubernetes.io/name selector label + asserts: + - equal: + path: metadata.labels["app.kubernetes.io/name"] + value: "git-hubby" + + - it: should set app.kubernetes.io/instance selector label + asserts: + - equal: + path: metadata.labels["app.kubernetes.io/instance"] + value: "test-release" + + - it: should set app.kubernetes.io/version label + asserts: + - equal: + path: metadata.labels["app.kubernetes.io/version"] + value: "0.4.5" + + - it: should set app.kubernetes.io/managed-by label + asserts: + - equal: + path: metadata.labels["app.kubernetes.io/managed-by"] + value: "Helm" + +