Configure PublishingExtension for WorldEdit Sponge#2761
Merged
Conversation
Currently, sponge api aren't be published to the maven repository (only the `pom`s are): https://maven.enginehub.org/repo/com/sk89q/worldedit/worldedit-sponge/7.4.0-SNAPSHOT/ Looks like the `worldedit-sponge` is just not configuring publishing: - Sponge (No `configure<PublishingExtension> `) - https://github.com/EngineHub/WorldEdit/blob/version/7.3.x/worldedit-sponge/build.gradle.kts - Bukkit (configures it) - https://github.com/EngineHub/WorldEdit/blob/version/7.3.x/worldedit-bukkit/build.gradle.kts#L110 - Fabric (configures it) - https://github.com/EngineHub/WorldEdit/blob/version/7.3.x/worldedit-fabric/build.gradle.kts#L71 Presumably since `worldedit-sponge` is missing: ```kt configure<PublishingExtension> { publications.named<MavenPublication>("maven") { from(components["java"]) } } ``` It doesn't get the information from the `java-library` plugin to actually include the jar, so it just includes the pom. Unfortunately I obviously don't have permission to publish the enginehub repository, but perhaps someone could take a look to see if this fix would work?
Collaborator
|
FWIW publishing behavior is testable locally via the |
Member
|
The POMs themselves may have issues (#1778) so a thorough verification of those should be done as well. |
Contributor
Author
|
Thanks for letting me know about |
wizjany
approved these changes
Apr 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, sponge api aren't be published to the maven repository (only the
poms are): https://maven.enginehub.org/repo/com/sk89q/worldedit/worldedit-sponge/7.4.0-SNAPSHOT/Looks like the
worldedit-spongeis just not configuring publishing:configure<PublishingExtension>) - https://github.com/EngineHub/WorldEdit/blob/version/7.3.x/worldedit-sponge/build.gradle.ktsPresumably since
worldedit-spongeis missing:It doesn't get the information from the
java-libraryplugin to actually include the jar, so it just includes the pom.Unfortunately I obviously don't have permission to publish the enginehub repository, but perhaps someone could take a look to see if this fix would work?